Jetsparrow/jetherald
1
0
Fork 0
mirror of https://github.com/Jetsparrow/jetherald.git synced 2026-01-20 23:56:08 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

LeakyBucket DateTime fixes

Browse Source 
- Remove use of local DateTime.Now
- Always take UtcNow only once at method entry
This commit is contained in:
jetsparrow 2021-10-16 22:09:42 +03:00
parent c8f505ba03
commit 415979c61e
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
JetHerald/LeakyBucket.cs
View File

@ -17,8 +17,9 @@ namespace JetHerald
public bool IsTimedOut(uint key) public bool IsTimedOut(uint key)
{ {
var debtLimit = DateTime.Now.AddSeconds(config.DebtLimitSeconds); var now = DateTime.UtcNow;
var time = expiryDates.GetValueOrDefault(key, DateTime.Now); var debtLimit = now.AddSeconds(config.DebtLimitSeconds);
var time = expiryDates.GetValueOrDefault(key, now);
Console.WriteLine(time); Console.WriteLine(time);
return time > debtLimit; return time > debtLimit;
} }
@ -26,11 +27,12 @@ namespace JetHerald
public void ApplyCost(uint key, int cost) public void ApplyCost(uint key, int cost)
{ {
expiryDates.AddOrUpdate(key, expiryDates.AddOrUpdate(key,
key => DateTime.Now.AddSeconds(cost), key => DateTime.UtcNow.AddSeconds(cost),
(key, oldDebt) => (key, oldDebt) =>
{ {
if (oldDebt < DateTime.Now) var now = DateTime.UtcNow;
return DateTime.Now.AddSeconds(cost); if (oldDebt < now)
return now.AddSeconds(cost);
return oldDebt.AddSeconds(cost); return oldDebt.AddSeconds(cost);
}); });